Changes between v2.22.1 and v2.22.2 -------------------------------------------- commit a924ef3f9da3ef07f2bbff2f6c211563fc62d97c Author: Karel Zak Date: Thu Dec 13 12:16:17 2012 +0100 build-sys: release++ (v2.22.2) Signed-off-by: Karel Zak NEWS | 4 ++++ configure.ac | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) commit 779dee00c82d79cf4d84864b662f2576cd79c702 Author: Karel Zak Date: Thu Dec 13 12:14:25 2012 +0100 docs: update v2.22.2-ReleaseNotes Signed-off-by: Karel Zak Documentation/releases/v2.22.1-ReleaseNotes | 2 +- Documentation/releases/v2.22.2-ReleaseNotes | 80 +++++++++++++++++++++++++++++ 2 files changed, 81 insertions(+), 1 deletion(-) commit 38879a24b7f313788b1c28a3a95553b66dc65de1 Author: Karel Zak Date: Thu Dec 13 12:07:29 2012 +0100 docs: update AUTHORS file Signed-off-by: Karel Zak AUTHORS | 3 +++ 1 file changed, 3 insertions(+) commit f6539f430dbeed6140ec4ef34de83f476cf3f05e Author: Karel Zak Date: Wed Dec 12 22:17:51 2012 +0100 po: merge changes Signed-off-by: Karel Zak po/ca.po | 554 ++++++------ po/cs.po | 2469 +++++++++++++++++++++++++++++++---------------------- po/da.po | 2161 ++++++++++++++++++++++++++-------------------- po/de.po | 554 ++++++------ po/es.po | 554 ++++++------ po/et.po | 554 ++++++------ po/eu.po | 554 ++++++------ po/fi.po | 554 ++++++------ po/fr.po | 555 ++++++------ po/gl.po | 554 ++++++------ po/hr.po | 1700 +++++++++++++++++++----------------- po/hu.po | 554 ++++++------ po/id.po | 554 ++++++------ po/it.po | 554 ++++++------ po/ja.po | 554 ++++++------ po/nl.po | 555 ++++++------ po/pl.po | 555 ++++++------ po/pt_BR.po | 554 ++++++------ po/ru.po | 554 ++++++------ po/sl.po | 554 ++++++------ po/sv.po | 554 ++++++------ po/tr.po | 554 ++++++------ po/uk.po | 555 ++++++------ po/util-linux.pot | 554 ++++++------ po/vi.po | 555 ++++++------ po/zh_CN.po | 554 ++++++------ po/zh_TW.po | 554 ++++++------ 27 files changed, 10423 insertions(+), 9208 deletions(-) commit 569518d154cfe6f70916b43b3f52bb9d4bc2ede3 Author: Joe Hansen Date: Wed Dec 12 21:57:56 2012 +0100 po: update da.po (from translationproject.org) po/da.po | 2320 +++++++++++++++++++++++++++----------------------------------- 1 file changed, 990 insertions(+), 1330 deletions(-) commit 8f821f63599e3b2d78a458e068686b7e13018dcd Author: Petr Pisar Date: Wed Dec 12 21:57:56 2012 +0100 po: update cs.po (from translationproject.org) po/cs.po | 2154 +++++++++++++++++++++++++------------------------------------- 1 file changed, 853 insertions(+), 1301 deletions(-) commit d691fb63e3f72478ab4d21b08a3295e9b4e3b386 Author: Karel Zak Date: Wed Dec 12 21:01:32 2012 +0100 libmount: fix typos Signed-off-by: Karel Zak libmount/src/utils.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) commit 2a5968e122bb1ddf39491c0c684a6380096e8903 Author: Karel Zak Date: Wed Dec 12 20:48:15 2012 +0100 blkid: fix double free [coverity scan] Signed-off-by: Karel Zak misc-utils/blkid.c | 1 + 1 file changed, 1 insertion(+) commit a03026dafd9f4d13c136fe3f5eb05256ab46ca5c Author: Karel Zak Date: Wed Dec 12 13:32:52 2012 +0100 libmount: make mkstemp() more robust [coverity scan] Signed-off-by: Karel Zak libmount/src/utils.c | 8 ++++++++ 1 file changed, 8 insertions(+) commit 3cac0b9438b4073d268b0e00aa35935ffa1874f3 Author: Karel Zak Date: Wed Dec 12 12:40:48 2012 +0100 swapon: fix memmory leak [coverity scan] Signed-off-by: Karel Zak sys-utils/swapon.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 4f87e2c0e53ec38be4ec00085b9d1d8737106e95 Author: Karel Zak Date: Wed Dec 12 12:27:05 2012 +0100 libblkid: check mkdir(/run/blkid) return code [coverity scan] Signed-off-by: Karel Zak libblkid/src/save.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) commit 08035c3747245d7229b6f01e4728d1e645fbd4c8 Author: Karel Zak Date: Wed Dec 12 11:48:08 2012 +0100 login: check lastlog lseek return code [coverity scan] Signed-off-by: Karel Zak login-utils/login.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 376bbc56beb0ee81a9b51b3ea2bb2b19a2c7e697 Author: Karel Zak Date: Wed Dec 12 10:48:01 2012 +0100 chsh: use return rather than exit in main, clean up man page Signed-off-by: Karel Zak login-utils/chsh.1 | 18 ++++++++++-------- login-utils/chsh.c | 17 ++++++++--------- 2 files changed, 18 insertions(+), 17 deletions(-) commit 5c37d7409542100e7673048c33b2864fca58ca2f Author: Karel Zak Date: Wed Dec 12 10:41:44 2012 +0100 chfn: always use return rather than exit() in main Signed-off-by: Karel Zak login-utils/chfn.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) commit 74919e647566d414fea955fdc8ccb007bfc99cbf Author: Karel Zak Date: Wed Dec 12 10:36:32 2012 +0100 chfn: clean up exit status The old version in some cases (but not always) returns -1 (255) on error. It seems better to cleanup the code and don't return internal return codes by exit(). Signed-off-by: Karel Zak login-utils/chfn.1 | 2 ++ login-utils/chfn.c | 11 +++++------ 2 files changed, 7 insertions(+), 6 deletions(-) commit 616b36dc21b693bb0c5b957948936adc2c2b30ae Author: Karel Zak Date: Mon Dec 10 12:25:25 2012 +0100 blkid: fix man page mess Signed-off-by: Karel Zak misc-utils/blkid.8 | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) commit 2b29c1bfca6e52c9c1ce2e41fde7967c150c5877 Author: Karel Zak Date: Tue Dec 4 13:02:57 2012 +0100 libblkid: re-read PART{UUID,LABEL} for successfully verified cached devices Signed-off-by: Karel Zak libblkid/src/verify.c | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) commit 8debdf76418ce66903895fd4a67bf2031f7566e1 Author: Karel Zak Date: Tue Nov 27 10:44:28 2012 +0100 lsblk: fix copy & past bug Signed-off-by: Karel Zak misc-utils/lsblk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit b049afb02565c2a209191fd7f4b3884fb1004705 Author: Karel Zak Date: Mon Nov 26 16:25:46 2012 +0100 umount: sanitize paths from non-root users Signed-off-by: Karel Zak sys-utils/umount.c | 34 ++++++++++++++++++++++++++++++++-- 1 file changed, 32 insertions(+), 2 deletions(-) commit b79ac1f007c8672d7fb18d535333cb9e1f59e1b2 Author: Karel Zak Date: Mon Nov 26 14:30:22 2012 +0100 mount: sanitize paths from non-root users $ mount /root/.ssh/../../dev/sda2 mount: only root can mount UUID=17bc65ec-4125-4e7c-8a7d-e2795064c736 on /boot this is too promiscuous. It seems better to ignore on command line specified paths which are not resolve-able for non-root users. Fixed version: $ mount /root/.ssh/../../dev/sda2 mount: /root/.ssh/../../dev/sda2: Permission denied $ mount /dev/sda2 mount: only root can mount UUID=17bc65ec-4125-4e7c-8a7d-e2795064c736 on /boot Note that this bug has no relation to mount(2) permissions evaluation in suid mode. The way how non-root user specifies paths on command line is completely irrelevant for comparison with fstab entries. Signed-off-by: Karel Zak sys-utils/mount.c | 35 +++++++++++++++++++++++++++++++++++ 1 file changed, 35 insertions(+) commit d342b443d5daec2c55734e93ba3b81a60ae6075f Author: Karel Zak Date: Mon Nov 26 16:24:28 2012 +0100 lib/canonicalize: add canonicalize_path_restricted() to canonicalize without suid permisssions Signed-off-by: Karel Zak include/canonicalize.h | 1 + lib/canonicalize.c | 42 ++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 43 insertions(+) commit 9a1aec7eba0743b47d015a1849befc7280a784ed Author: Karel Zak Date: Mon Nov 26 12:19:02 2012 +0100 libmount: make debug stuff more robust Signed-off-by: Karel Zak libmount/src/mountP.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit a4c8560d796748d1384afb9698415062f441df35 Author: Sami Kerola Date: Tue Oct 23 20:50:38 2012 +0100 docs: remove dead link Signed-off-by: Sami Kerola Documentation/howto-contribute.txt | 3 --- 1 file changed, 3 deletions(-) commit 51a1ec4cb986f3f2c89d875ad33eed5f24663459 Author: Richard W.M. Jones Date: Mon Nov 19 15:02:13 2012 +0000 wipefs: Add --force option to force it to erase. Commit c550f728f724360f99aae0fdb45b0589d9a347e0 added O_EXCL when opening the thing to erase. This broke the wipefs utility when used on anything which isn't an unmounted filesystem. eg. If you use it on a block device containing partitions, then it won't work because the kernel recognizes the partitions and so thinks the device is in use. This change adds the --force option which, when used, undoes the above flag change. However you still have to use --force most of the time when erasing something that isn't a plain unmounted filesystem. Signed-off-by: Richard W.M. Jones misc-utils/wipefs.8 | 3 +++ misc-utils/wipefs.c | 19 +++++++++++++++---- 2 files changed, 18 insertions(+), 4 deletions(-) commit 6f545688d66024f1e3c84aa7945f4674f2822139 Author: Karel Zak Date: Mon Nov 26 11:21:40 2012 +0100 libmount: correctly interpret '*' from /etc/filesystems - single line with '*' in /etc/filesystems means that libmount has to read /proc/filesystems, otherwise /proc/filesystems has to be ignored - mount(2) ENODEV is no reason to break the do_mount_by_pattern() loop when trying to mount by /{etc,proc}/filesystems Reported-by: NeilBrown Signed-off-by: Karel Zak libmount/src/context_mount.c | 3 ++- libmount/src/utils.c | 29 ++++++++++++++++++++++++----- 2 files changed, 26 insertions(+), 6 deletions(-) commit a8894c5b25668e1132efeed862f4671464b63b5e Author: Karel Zak Date: Wed Nov 21 15:47:56 2012 +0100 libblkid: (gpt) don't modify in memory buffers LIBBLKID_DEBUG=0xffff blkid -p .... gpt: ---> call probefunc() reuse buffer: off=0 len=1024 pr=0xb0b690 reuse buffer: off=0 len=1024 pr=0xb0b690 reuse buffer: off=1024 len=16384 pr=0xb0b690 GPT entries corrupted reuse buffer: off=10737417728 len=512 pr=0xb0b690 reuse buffer: off=10737401344 len=16384 pr=0xb0b690 GPT entries corrupted gpt: <--- (rc = 1) Reported-by: Dave Reisner Signed-off-by: Karel Zak libblkid/src/partitions/gpt.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) commit df4b188757ff40856562e7993927f788b48948e4 Author: Karel Zak Date: Mon Nov 19 09:50:08 2012 +0100 uuidgen: fix --random Addresses: https://github.com/karelzak/util-linux/issues/20 Signed-off-by: Karel Zak misc-utils/uuidgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 322796e74a0ebc20802d1665d0b3900f3f9d90a6 Author: Karel Zak Date: Tue Nov 13 10:36:25 2012 +0100 lscpu: make read_topology() more robust to avoid SIGFPE Signed-off-by: Karel Zak sys-utils/lscpu.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) commit 2c416a25903341a579ca6ba2feecb8e893d1e735 Author: Gleb Fotengauer-Malinovskiy Date: Thu Sep 27 20:48:34 2012 +0400 libmount: fix support of comma-separated fs types lists # grep cdrom /etc/fstab /dev/sr0 /media/cdrom udf,iso9660 ro,noauto,user,utf8 0 0 # mount /media/cdrom mount: unknown filesystem type 'udf,iso9660' # mount -t udf,iso9660 /dev/sr0 /media/cdrom mount: /dev/sr0 is write-protected, mounting read-only [kzak@redhat.com: - add some comments - don't try to found external helpers for the types] Signed-off-by: Gleb Fotengauer-Malinovskiy Signed-off-by: Karel Zak libmount/src/context.c | 10 ++++++---- libmount/src/context_mount.c | 10 +++++++--- 2 files changed, 13 insertions(+), 7 deletions(-) commit e89708820cdc08238ae2fb60f8af45ad4b161d38 Author: Karel Zak Date: Thu Nov 15 16:42:05 2012 +0100 libmount: don't reset NOSWAPMATCH context flag Signed-off-by: Karel Zak libmount/src/context.c | 1 + 1 file changed, 1 insertion(+) commit f6bb5f20e1efbfe96dac51269fa9a1312a5d7a7d Author: Karel Zak Date: Thu Nov 15 15:59:59 2012 +0100 libmount: don't try to play with loopdevs if umount argument is really mountpoint Signed-off-by: Karel Zak libmount/src/context_umount.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) commit 35440095939ef675f13edd3ef87e1d97a6106e3d Author: Karel Zak Date: Thu Nov 15 15:35:24 2012 +0100 libmount: more robust tab filter usage Signed-off-by: Karel Zak libmount/src/context.c | 5 +++++ libmount/src/tab_parse.c | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) commit bc899bea389ca3aa915bd985664fd8babbc00d6a Author: Karel Zak Date: Wed Nov 14 13:14:29 2012 +0100 libblkid: remove obsolete tags from cache The libblkid cache tags are not removed if a new version of the tags is empty (e.g. label 'foo' -> ''). # mkfs.ext4 -L test_label /dev/sda15 # blkid /dev/sda15 /dev/sda15: LABEL="test_label" # tune2fs -L '' /dev/sda15 # blkid /dev/sda15 /dev/sda15: LABEL="test_label" ^^^^^^^^^^ Reported-by: Mike Fleetwood Signed-off-by: Karel Zak libblkid/src/tag.c | 2 +- libblkid/src/verify.c | 20 ++++++++++++++++++++ 2 files changed, 21 insertions(+), 1 deletion(-) commit 12b0feeb2d3df6eca1655d54c4687b4f393870de Author: Karel Zak Date: Tue Nov 13 16:50:02 2012 +0100 umount: allways return MOUNT_EX_* Signed-off-by: Karel Zak sys-utils/umount.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 03cbd8878d8534528bd42328d3da3c5bfb40daed Author: Karel Zak Date: Mon Nov 12 15:00:24 2012 +0100 tests: remove lscpu /sys dumps without 'possible' CPU mask Signed-off-by: Karel Zak tests/ts/lscpu/dumps/i386-amdshanghai.tar.gz | Bin 3395 -> 0 bytes tests/ts/lscpu/dumps/i386-dellpe700.tar.gz | Bin 799 -> 0 bytes tests/ts/lscpu/dumps/i386-intels5000phb.tar.gz | Bin 2865 -> 0 bytes tests/ts/lscpu/dumps/ia64-512cpus.tar.gz | Bin 67254 -> 0 bytes tests/ts/lscpu/dumps/ia64-hpmatterhorn.tar.gz | Bin 3514 -> 0 bytes tests/ts/lscpu/dumps/ia64-hprx1620.tar.gz | Bin 1384 -> 0 bytes tests/ts/lscpu/dumps/ia64-pg0.tar.gz | Bin 7784 -> 0 bytes tests/ts/lscpu/dumps/sparc64-UltraSparc-T1.tar.gz | Bin 23071 -> 0 bytes tests/ts/lscpu/dumps/x86_64-dell_poweredge1950.tar.gz | Bin 1492 -> 0 bytes tests/ts/lscpu/dumps/x86_64-dell_poweredgeR610.tar.gz | Bin 14095 -> 0 bytes tests/ts/lscpu/dumps/x86_64-dellr710.tar.gz | Bin 14300 -> 0 bytes tests/ts/lscpu/dumps/x86_64-el5xen.tar.gz | Bin 7296 -> 0 bytes tests/ts/lscpu/dumps/x86_64-hpdl585.tar.gz | Bin 6910 -> 0 bytes tests/ts/lscpu/dumps/x86_64-ibme326m.tar.gz | Bin 1461 -> 0 bytes tests/ts/lscpu/dumps/x86_64-necem14.tar.gz | Bin 1307 -> 0 bytes 15 files changed, 0 insertions(+), 0 deletions(-) commit e299cfc4a1ec01519aa5b6c7d4f62b102e9b18d1 Author: Toshi Kani Date: Tue Oct 23 13:49:46 2012 -0600 lscpu: Fix issue found on CPU hot-remove read_basicinfo() relies on sysfs cpu directories "/sys/devices/system/cpu/cpu%d" with assumption that cpu logical number %d is always sequentially assigned for all CPUs. However, this assumption is not correct with CPU hot-remove operation since it removes a target sysfs cpu directory after it is ejected. As a result, lscpu may not recognize all CPUs. The issue can be easily reproduced on KVM or VirtualBox, which supports CPU eject operation, as follows. 1) The system has 4 CPUs $ lscpu -a -e CPU NODE SOCKET CORE L1d:L1i:L2 ONLINE 0 0 0 0 0:0:0 yes 1 0 1 1 1:1:1 yes 2 0 2 2 2:2:2 yes 3 0 3 3 3:3:3 yes 2) Eject cpu2 # echo 1 > /sys/bus/acpi/devices/LNXCPU:02/eject 3) lscpu no longer recognizes cpu3 after cpu2 is ejected $ lscpu -a -e CPU NODE SOCKET CORE L1d:L1i:L2 ONLINE 0 0 0 0 0:0:0 yes 1 0 1 1 1:1:1 yes The following changes are made to address this issue. - Use maxcpus to allocate and parse bitmaps. - Set desc->ncpu from cpu/present, which includes both on-line and off-line CPUs. - Add is_cpu_present() to check if a CPU is present. Ejected CPUs are not present. [kzak@redhat.com: - read also /sys/devices/system/cpu/possible mask to determine maximal number of CPUs, - err() if possible mask is not found in /sys] Signed-off-by: Toshi Kani Signed-off-by: Karel Zak sys-utils/lscpu.c | 66 ++++++++++++++++++++++++++++++++++++------------------- 1 file changed, 44 insertions(+), 22 deletions(-) commit b7e6adc0dee178c7ea3981a1fd29cbb2015d67b0 Author: Karel Zak Date: Mon Nov 12 12:10:52 2012 +0100 lib/loopdev: make loopcxt_get_device() more robust Signed-off-by: Karel Zak lib/loopdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 2198b363f07fb10bf54dd2d564ce1bb2981b5d25 Author: Sami Kerola Date: Tue Nov 6 21:14:14 2012 +0000 script: do not try to close stderr twice The commit cdd2a8c360c70d16804ace7cc923a6c6bb7c9ca9 broke script(1) return value. $ script -e -c "echo"; echo $? 1 The reason, as Daniel it reported, was that the script will close stderr twice, once as timing file and atexit() in function close_stdout(). This commit fixes the problem. Reported-by: Daniel Narvaez Signed-off-by: Sami Kerola term-utils/script.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit cb187bc79c4e2166af391beb27f7bb05967fa08e Author: Michal Schmidt Date: Mon Oct 29 23:33:01 2012 +0100 agetty: fix autodetection for TERM open_tty() autodetects whether to set TERM to "linux" or "vt102", but it can apply the result only if op->term is still NULL. term-utils/agetty.c | 1 - 1 file changed, 1 deletion(-) commit a3528342bc716ecdabdd86609ae5a3198f560870 Author: Karel Zak Date: Tue Oct 23 12:40:39 2012 +0200 misc: make readlink() usage more robust Signed-off-by: Karel Zak misc-utils/lsblk.c | 4 ++-- misc-utils/lslocks.c | 2 +- sys-utils/eject.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) commit ed68f1e2f5609a3f42492df407d62b8fc006ea17 Author: Karel Zak Date: Mon Oct 22 13:13:02 2012 +0200 login: fix compiler warning [-Wunused-result] It's probably unnecessary paranoia, but let's check if we're able to restore the original IDs after ~/.hushlogin file check. Signed-off-by: Karel Zak login-utils/login.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) commit 75f03f036011003c2a9e8e634ca3ce7930873318 Author: Karel Zak Date: Mon Oct 22 10:10:55 2012 +0200 fsck.cramfs: compile with -DINCLUDE_FS_TESTS for make check make check sudo su - cd tests ./run.sh cramfs Signed-off-by: Karel Zak disk-utils/Makemodule.am | 5 +++++ tests/commands.sh | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) commit 939636dd664cc608232c272de77be96e6f089235 Author: Karel Zak Date: Wed Oct 17 11:43:39 2012 +0200 lib/loopdev: check for /sys The current loopdev code prefers /sys to get information about loop devices. The old methods like scan /dev are fallback solution only. Unfortunately, the code does not check if /sys is mounted. Addresses: http://blog.flameeyes.eu/2012/10/sophistication-can-be-bad Signed-off-by: Karel Zak lib/loopdev.c | 6 ++++++ 1 file changed, 6 insertions(+) commit deb0e659451d4ade29df3dbb842607edd6080c0d Author: Karel Zak Date: Wed Oct 17 11:42:21 2012 +0200 lib/loopdev: improve debug messages Signed-off-by: Karel Zak lib/loopdev.c | 22 ++++++++++++++++++---- sys-utils/losetup.c | 2 -- 2 files changed, 18 insertions(+), 6 deletions(-) commit b426209c5ba2126a9038363a269fec884af470fb Author: Bill Pemberton Date: Wed Oct 10 16:54:02 2012 -0400 mount: add long options for -L and -U to man page The -L and -U flags both have long options too (--label and --uuid). The usage() function will show them but the man page didn't list them. Signed-off-by: Bill Pemberton sys-utils/mount.8 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) commit 532116d4dd16632806ed4a036c2e89b966221031 Author: Bill Pemberton Date: Wed Oct 10 16:54:01 2012 -0400 mount: add -c abbreviation for --no-canonicalize to man page The --no-canonicalize option can also be set using -c. The --help for mount shows this option but the man page did not. Add -c to the man page. Signed-off-by: Bill Pemberton sys-utils/mount.8 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 9f6c8591eeffb6591dc6a18512e618f0acf09890 Author: Karel Zak Date: Mon Oct 15 17:01:30 2012 +0200 libblkid: fix compiler warning [-Wstrict-aliasing] libblkid/src/superblocks/befs.c: In function 'get_uuid': libblkid/src/superblocks/befs.c:353:6: warning: dereferencing type-punned pointer will break strict-aliasing rules [-Wstrict-aliasing] Signed-off-by: Karel Zak libblkid/src/superblocks/befs.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) commit 10a9cbcf36d43c0d4a13bf5e91315b4ffd29e636 Author: Sami Kerola Date: Mon Oct 8 08:08:20 2012 +0100 swapon: remove loop declaration [smatch scan] sys-utils/swapon.c:677:2: error: 'for' loop initial declarations are only allowed in C99 mode Signed-off-by: Sami Kerola sys-utils/swapon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) commit 9faf9c8494cf37fdcf68b1dfe10fd7900e93ec00 Author: Karel Zak Date: Mon Oct 15 12:38:09 2012 +0200 wipefs: use O_EXCL Address: https://bugzilla.redhat.com/show_bug.cgi?id=865961 Signed-off-by: Karel Zak misc-utils/wipefs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) commit 6eeca6c7170295f325b814ee0cd1576da885cd30 Author: Karel Zak Date: Mon Oct 15 11:10:50 2012 +0200 libmount: don't use umount optimization for -l or -f The options -l (lazy) and -f (force) means that the mountpoint may be unreadable (for example because NFS server is unreadable). So we should not try to be smart in this case and we should try to minimize number of situations when stat() or readlink() is used for the mountpoint. Signed-off-by: Karel Zak libmount/src/context_umount.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)